michael-s-molina commented on code in PR #24206:
URL: https://github.com/apache/superset/pull/24206#discussion_r1205760572
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx:
##########
@@ -187,13 +188,10 @@ const FilterValue: React.FC<FilterControlProps> = ({
handleFilterLoadFinish();
})
.catch((error: Response) => {
- getClientErrorObject(error).then(parsedError => {
- errorRef.current = error.errors?.[0];
+ getClientErrorObject(error).then(clientErrorObject => {
+ setError(clientErrorObject);
+ handleFilterLoadFinish();
});
- setError(
- error.message || error.error || t('Check configuration'),
Review Comment:
Looking at `getClientErrorObject` implementation, and error is always
returned and it deals with the generic case as well. In my opinion it offers a
more standard treatment to the exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
