marregui commented on PR #24172: URL: https://github.com/apache/superset/pull/24172#issuecomment-1564967769
Hola, I have added unit tests and also removed unnecesary overrides in the engine spec for QuestDB. The tests pass locally and I have finally realised the existence of pre-commit hooks, so the code pylints well. For some reason CI is not triggering. I have added a dependency to https://pypi.org/project/questdb-connect/0.0.97/ which is the version of questdb-connect that does not contain the implementation of the QuestDB engine spec. There is a version 1.0.7 that simply adds a copy of the engine spec. I tested superset master with questdb-connect 0.0.97, it works well afaict. Regards -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
