[GitHub] [superset] hughhhh commented on a diff in pull request #24248: fix: save columns reference from sqllab save datasets flow

[via GitHub]

hughhhh commented on code in PR #24248:
URL: https://github.com/apache/superset/pull/24248#discussion_r1213718535


##########
superset-frontend/src/explore/components/SaveModal.tsx:
##########
@@ -174,15 +174,13 @@ class SaveModal extends React.Component<SaveModalProps, 
SaveModalState> {
       if (this.props.datasource?.type === DatasourceType.Query) {
         const { schema, sql, database } = this.props.datasource;
         const { templateParams } = this.props.datasource;
-        const columns = this.props.datasource?.columns || [];
 
         await this.props.actions.saveDataset({
           schema,
           sql,
           database,
           templateParams,
           datasourceName: this.state.datasetName,
-          columns,

Review Comment:
   in the original `superset/sqllab_viz` endpoint we had to build out these 
object ourselves so intially that I needed to add the logic but realize soon 
after it was builtin



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org