john-bodley commented on code in PR #23997:
URL: https://github.com/apache/superset/pull/23997#discussion_r1223560026
##########
superset/charts/schemas.py:
##########
@@ -1159,10 +1151,7 @@ class Meta: # pylint: disable=too-few-public-methods
)
filters = fields.List(fields.Nested(ChartDataFilterSchema),
allow_none=True)
granularity = fields.String(
- metadata={
- "description": "Name of temporal column used for time filtering. "
- "For legacy Druid datasources this defines the time grain."
- },
+ metadata={"description": "Name of temporal column used for time
filtering. "},
Review Comment:
@michael-s-molina I _believe_ your question is somewhat akin to the
conversation with @villebro where the term "granularity" is overloaded. Per the
augmented `description` you can see it referred to the time gran for Druid
NoSQL connector (which is now obsolete), however it also is used to represent
the temporal time column for the SQL connector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
