justinpark opened a new pull request, #24371:
URL: https://github.com/apache/superset/pull/24371

   ### SUMMARY
   Similar to https://github.com/apache/superset/pull/23488, 
https://github.com/apache/superset/pull/23257 and 
https://github.com/apache/superset/pull/24082, this commit migrates the table 
metadata(and extra metadata) state from redux to rdk-query to reduce the 
complexity of the sqlLab state.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   After:
   
   <img width="381" alt="Screenshot 2023-06-12 at 4 18 37 PM" 
src="https://github.com/apache/superset/assets/1392866/bb754707-9f80-4558-9a30-fd4b9baa5627";>
   
   Before:
   
   <img width="525" alt="Screenshot 2023-06-12 at 5 37 10 PM" 
src="https://github.com/apache/superset/assets/1392866/b64cdd65-d5ee-4661-be38-7599f228c211";>
   
   ### TESTING INSTRUCTIONS
   Go to sqllab and select/remove table options from the left menu
   check the table metadata including columns and indices
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to