villebro commented on code in PR #24359:
URL: https://github.com/apache/superset/pull/24359#discussion_r1227664145
##########
superset-frontend/src/profile/components/fixtures.tsx:
##########
@@ -29,7 +29,6 @@ export const user: UserWithPermissionsAndRoles = {
],
sql_lab: [
['menu_access', 'SQL Lab'],
- ['can_sql_json', 'Superset'],
Review Comment:
hmm, don't we need to add the new API perms to these fixtures? Maybe they're
not covered by the current tests, so maybe we can add them later when they're
needed..
##########
superset/security/manager.py:
##########
@@ -713,6 +712,7 @@ def create_custom_permissions(self) -> None:
self.add_permission_view_menu("all_datasource_access",
"all_datasource_access")
self.add_permission_view_menu("all_database_access",
"all_database_access")
self.add_permission_view_menu("all_query_access", "all_query_access")
+ self.add_permission_view_menu("can_csv", "Superset")
Review Comment:
Would this new perm combine both CSV/XLSX etc downloading, and
chart/dashboard image downloading? I think that could make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
