john-bodley commented on PR #24447: URL: https://github.com/apache/superset/pull/24447#issuecomment-1599182276
Thanks @giftig. Would you mind adding a unit test as well? This helps both with reviewing the PR and ensures we don't regress in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
