michael-s-molina commented on code in PR #24477:
URL: https://github.com/apache/superset/pull/24477#discussion_r1239792372
##########
superset-frontend/packages/superset-ui-core/src/chart/models/ChartProps.ts:
##########
@@ -88,6 +95,8 @@ export interface ChartPropsConfig {
ownState?: JsonObject;
/** Filter state that saved in dashboard */
filterState?: FilterState;
+ /** Legend state */
+ legendState?: LegendState;
Review Comment:
I totally agree with your concern. I have many other concerns regarding the
current plugin architecture but I think the best approach would be to stop
amending the flawed design and think about a cleaner v2. One thing I think is
really hard with the current structure is to properly test the plugin behaviors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
