sebastianliebscher commented on code in PR #24129: URL: https://github.com/apache/superset/pull/24129#discussion_r1240892397
########## requirements/testing.txt: ########## @@ -85,6 +101,8 @@ parameterized==0.9.0 # via -r requirements/testing.in pathable==0.4.3 # via jsonschema-spec +prophet==1.1.3 Review Comment: If I think about it: `"prophet": ["prophet>=1.1.0, <2.0.0"],` would always install latest prophet 1.x, but CI would only test the pinned release. Maybe we should pin prophet in `setup.py`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org