villebro opened a new pull request, #24513: URL: https://github.com/apache/superset/pull/24513
### SUMMARY #24422 introduced a regression, which caused SQL Lab results to not show up in SQL Lab for clients that had a negative TZ offset. This was due to the backend returning timestamps that don't include the Zulu prefix to indicate that the timestamp is in UTC TZ. Due to parsing this using `Date.parse()` in the frontend, this timestamp was assumed to be in local timezone, causing an inconsistency when requesting updated queries using the epoch. This fixes the issue by using the `normalizeTimestamp` function from `@superset-ui/core`, and adds tests to ensure that `queriesLastUpdate` in Redux state are correctly normalized. This test would previously have failed on master branch when run in non-UTC TZ. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: fixes #24487 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
