betodealmeida opened a new pull request, #24547: URL: https://github.com/apache/superset/pull/24547
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR is part 1 of 2. It adds a new input to the Alerts & Reports create/edit modals, as well as the report modal from charts and dashboards. In the new input users can configure a custom width for the screenshots This PR updates the model, adds the migration to introduce a `custom_width` column (and `custom_height`, though it's not used), and add the affordances to set the custom width in the create/edit flows. The next PR will read the information from the DB and use it when running the alerts and reports. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> New:   ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Create a few alerts & reports with custom width, then check the DB: ``` customize_screenshot_width=# SELECT id, custom_width FROM report_schedule; id | custom_width ----+-------------- 2 | 760 3 | 600 1 | 750 (3 rows) ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
