cwegener commented on code in PR #24578:
URL: https://github.com/apache/superset/pull/24578#discussion_r1252376936
##########
superset/examples/utils.py:
##########
@@ -44,28 +44,30 @@ def load_examples_from_configs(
def load_contents(load_test_data: bool = False) -> dict[str, Any]:
"""Traverse configs directory and load contents"""
- root = Path("examples/configs")
- resource_names = resource_listdir("superset", str(root))
- queue = [root / resource_name for resource_name in resource_names]
+ root = files("superset") / "examples/configs"
+ resource_names = (files("superset") / str(root)).iterdir()
+ queue = [root / str(resource_name) for resource_name in resource_names]
contents: dict[Path, str] = {}
while queue:
path_name = queue.pop()
test_re = re.compile(r"\.test\.|metadata\.yaml$")
- if resource_isdir("superset", str(path_name)):
+ if (files("superset") / str(path_name)).is_dir():
queue.extend(
- path_name / child_name
- for child_name in resource_listdir("superset", str(path_name))
+ path_name / str(child_name)
Review Comment:
Good question. I'll double check. I might have been blindly following `mypy`
errors. Now I'm not sure if the `mypy` errors were even valid errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
