nigzak opened a new issue, #24619:
URL: https://github.com/apache/superset/issues/24619
If you install standard Prophet 1.1.4 (current version) it also installs as
dependency holidays 0.28
This holiday version is incompatible with superset and results to crashing
pod (superset DB update & more does not work)
#### How to reproduce the bug
pull image 2.1.0
install prophet inside image
### Expected results
Installation works, no issues
### Actual results
pod is not working, init/db upgrade failing
```
kubectl -n <....> exec supers-54fbb77f8-mtbgn superset db upgrade
kubectl exec [POD] [COMMAND] is DEPRECATED and will be removed in a future
version. Use kubectl exec [POD] -- [COMMAND] instead.
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py",
line 568, in _build_master
ws.require(__requires__)
File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py",
line 886, in require
needed = self.resolve(parse_requirements(requirements))
File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py",
line 777, in resolve
raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (holidays 0.28
(/usr/local/lib/python3.8/site-packages),
Requirement.parse('holidays<0.18,>=0.17.2'), {'apache-superset'})
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/bin/superset", line 33, in <module>
sys.exit(load_entry_point('apache-superset', 'console_scripts',
'superset')())
File "/usr/local/bin/superset", line 25, in importlib_load_entry_point
return next(matches).load()
File "/usr/local/lib/python3.8/importlib/metadata.py", line 77, in load
module = import_module(match.group('module'))
File "/usr/local/lib/python3.8/importlib/__init__.py", line 127, in
import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
File "<frozen importlib._bootstrap>", line 991, in _find_and_load
File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 843, in exec_module
File "<frozen importlib._bootstrap>", line 219, in
_call_with_frames_removed
File "/app/superset/cli/main.py", line 28, in <module>
from superset.cli.lib import normalize_token
File "/app/superset/cli/lib.py", line 20, in <module>
from superset import config
File "/app/superset/config.py", line 51, in <module>
import pkg_resources
File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py",
line 3243, in <module>
def _initialize_master_working_set():
File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py",
line 3226, in _call_aside
f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py",
line 3255, in _initialize_master_working_set
working_set = WorkingSet._build_master()
File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py",
line 570, in _build_master
return cls._build_from_requirements(__requires__)
File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py",
line 583, in _build_from_requirements
dists = ws.resolve(reqs, Environment())
File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py",
line 772, in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'holidays<0.18,>=0.17.2'
distribution was not found and is required by apache-superset
command terminated with exit code 1
```
#### Additional Hints
Prophet 1.1.4 uses minimum holidays 0.20, default installing 0.28 (latest
version)
https://github.com/facebook/prophet/releases
Holidays Release latest versions currently brings more regions
https://python-holidays.readthedocs.io/en/latest/changelog.html
Found a merge, could be that this request is mostly satisfied with this
merge which is not in superset V2.1 - in this merge it is holidays-V0.20 and
not V0.28 (don't know if there are breaking changes between?)
https://github.com/facebook/prophet/pull/2379
If this merge already fixes this issue here please let me know, I am not to
deep in the PIP versionings/dependencies to understand them all ... only got
the error installing prophet that nothing worked with superset V2.1 (superset
update killed all, cannot use the installed environment on my DEV cluster)
### Environment
(please complete the following information):
- superset version: `2.1.0 docker image`
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version
of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't
found one similar. => POSSIBLE MERGE FOUND (?)
### Additional context
recommend to update holiday package in superset to the actual version 0.28
which also includes more regions
### Workaround
Installing prophet and superset with dedicated versions avoids killing the
pod completly. This should only be temporary used, don't know if prophet 1.1.3
getting problems in case of security (?)
```
pip install --no-cache ...<other packages>... holidays==0.17.2
prophet==1.1.3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
