villebro commented on code in PR #24618:
URL: https://github.com/apache/superset/pull/24618#discussion_r1256491952
##########
superset/config.py:
##########
@@ -1640,7 +1643,7 @@ class ExtraDynamicQueryFilters(TypedDict, total=False):
try:
# pylint: disable=import-error,wildcard-import,unused-wildcard-import
import superset_config
- from superset_config import * # type: ignore
+ from superset_config import *
Review Comment:
yeah this is a major annoyance - I don't know why it complains locally, but
for some weird reason it doesn't pass CI 🤦 Must be mismatching versions, I can
take a look sometime next week. In the meantime, just revert that change and do
good ol' `git commit --amend --no-verify` or similar
##########
superset/config.py:
##########
@@ -1640,7 +1643,7 @@ class ExtraDynamicQueryFilters(TypedDict, total=False):
try:
# pylint: disable=import-error,wildcard-import,unused-wildcard-import
import superset_config
- from superset_config import * # type: ignore
+ from superset_config import *
Review Comment:
yeah this is a major annoyance - I don't know why it complains locally, but
for some weird reason it doesn't pass CI 🤦 Must be mismatching versions, I can
take a look sometime next week. In the meantime, just revert that change and do
good ol' `git commit --amend --no-verify` or similar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
