gadhagod opened a new pull request, #24649:
URL: https://github.com/apache/superset/pull/24649

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly](docs: update Rockset usage (include 
virtual instance configuration)
   -->
   
   chore: bump rockset
   docs: update Rockset usage (include virtual instance configuration)
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   superset used a very old version of `rockset` (0.8.10). The latest version 
is 2.0.0. However, SQLAlchemy support no longer comes with `rockset` and has 
been separated into its own package, 
[`rockset-sqlalchemy`](https://pypi.org/project/rockset-sqlalchemy/). I have 
updated `setup.py` to reference this new package. This change should be 
completely backward compatible.
   
   This new package comes with the ability to target specific [virtual 
instances](https://rockset.com/docs/instances/) through the SQLAlchemy 
connection URI. I have updated the docs to show this new feature.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   <img width="1058" alt="Screenshot 2023-07-10 at 11 23 55 AM" 
src="https://github.com/apache/superset/assets/69025547/97152550-0714-4206-82c8-03b02a251f05";>
   
   After:
   <img width="1038" alt="Screenshot 2023-07-10 at 11 24 05 AM" 
src="https://github.com/apache/superset/assets/69025547/518b29af-c0de-45ff-af4a-3e7872203a2b";>
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   Updated instructions on using the new superset integration with Rockset will 
be on the Rockset docs soon. Until then, I will mark this PR as a draft. After 
that, I'll link those testing instructions here.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: 
https://github.com/rockset/rockset-python-client/issues/3
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to