john-bodley commented on code in PR #24647:
URL: https://github.com/apache/superset/pull/24647#discussion_r1260008093
##########
setup.py:
##########
@@ -92,7 +92,7 @@ def get_git_sha() -> str:
"geopy",
"gunicorn>=20.1.0; sys_platform != 'win32'",
"hashids>=1.3.1, <2",
- "holidays>=0.23, <0.24",
+ "holidays>=0.28, <0.29",
Review Comment:
Typically the upper bound should be exclusive of the next major version
(assuming it follows semver notation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
