michael-s-molina commented on code in PR #24665:
URL: https://github.com/apache/superset/pull/24665#discussion_r1260154402
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/buildQuery.ts:
##########
@@ -30,7 +30,10 @@ import {
import { PivotTableQueryFormData } from '../types';
export default function buildQuery(formData: PivotTableQueryFormData) {
- const { groupbyColumns = [], groupbyRows = [] } = formData;
+ const { groupbyColumns = [], groupbyRows = [], extra_form_data } = formData;
Review Comment:
Thank you for the references @hughhhh. I added the tests with modifications.
One tip: you can ask Chat GPT to avoid using `describe` and `it` blocks to
generate tests that conform to our [best
practices](https://github.com/apache/superset/wiki/Testing-Guidelines-and-Best-Practices#avoid-nesting-when-youre-testing)
😉
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/buildQuery.ts:
##########
@@ -30,7 +30,10 @@ import {
import { PivotTableQueryFormData } from '../types';
export default function buildQuery(formData: PivotTableQueryFormData) {
- const { groupbyColumns = [], groupbyRows = [] } = formData;
+ const { groupbyColumns = [], groupbyRows = [], extra_form_data } = formData;
Review Comment:
Thank you for the references @hughhhh. I added the tests with modifications.
One tip: you can ask Chat GPT to avoid using `describe` and `it` blocks to
generate tests that conform to our [best
practices](https://github.com/apache/superset/wiki/Testing-Guidelines-and-Best-Practices#avoid-nesting-when-youre-testing)
😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
