zhaoyongjie commented on PR #21767: URL: https://github.com/apache/superset/pull/21767#issuecomment-1632377928
> @bilalabdullah44000 You need to use Time Column filter and Time Range filter together to select multiple time filter, but I also found this feature was not correct work on the master, the Time Range replaced all of the value of time filters. I suggest that the first step revert the PR #23021 and then try to fix it in your side. > > <img alt="image" width="1398" src="https://user-images.githubusercontent.com/2016594/252954541-d311b2ca-fcc6-46e4-9802-d79189435d70.png";> By this feature, I think we should redesign the Time Filter on the Dashboard, should merge the Time Column/Time Range/Time Grain together as a unique Time Filter. Unfortunately, the new Time Filter almost didn't support multiple filters on the Dashboard, and some codebase was broken previous design, ---- the Native Filter should **APPEND** the new _where clause_ rather than **REPLACE** value of filter of chart. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/2016594/252954541-d311b2ca-fcc6-46e4-9802-d79189435d70.png"](https://user-images.githubusercontent.com/2016594/252954541-d311b2ca-fcc6-46e4-9802-d79189435d70.png"){kind=link}