justinpark commented on PR #24559: URL: https://github.com/apache/superset/pull/24559#issuecomment-1633182084
> Thanks for the change justinpark! I am worried that because the icons are so similar and close to each other, people might confuse them. I think in other places we use this icon (below) and using this one would probably help. Would it be ok to swap? <img alt="image" width="430" src="https://user-images.githubusercontent.com/36897697/252910739-e5957cdd-d33f-44a0-b4dd-e878ee93824e.png";> > > I think in general we have to bump the width of the modal in the default mode to ~880px (and resize just after it not longer fits in the screen), so that everything is more visible. Do you think you could include it in the PR or should it be included in a new one? Sounds good. I updated the location of the button to the next of the footer buttons. <img width="283" alt="Screenshot 2023-07-12 at 1 33 09 PM" src="https://github.com/apache/superset/assets/1392866/5101ce99-097a-430a-af02-a12068d67848";> I also updated the default width to 880px as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
![https://user-images.githubusercontent.com/36897697/252910739-e5957cdd-d33f-44a0-b4dd-e878ee93824e.png"](https://user-images.githubusercontent.com/36897697/252910739-e5957cdd-d33f-44a0-b4dd-e878ee93824e.png"){kind=link}