justinpark opened a new pull request, #24677: URL: https://github.com/apache/superset/pull/24677
### SUMMARY Following-up #24611, this commit adds specs for autocomplete regression by refactoring the logic into a dedicate hook. In addition to the refactoring, this commit also fixes the unnecessary iterations for generating autocomplete items. This performance improvement enables the autocomplete with a large-size metadata set. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF After: (able to interact with autocomplete in a large set) https://github.com/apache/superset/assets/1392866/76abc16d-05f5-4254-8480-38b9bdcdb29f Before: (impossible to interact with autocomplete in a large set) https://github.com/apache/superset/assets/1392866/9c6a72c8-1471-4e72-9626-9d85647c2c04 ### TESTING INSTRUCTIONS Go to SQL lab and enable autocomplete ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
