abelstam12 opened a new issue, #24727:
URL: https://github.com/apache/superset/issues/24727

   *Please make sure you are familiar with the SIP process documented*
   (here)[https://github.com/apache/superset/issues/5602]. The SIP will be 
numbered by a committer upon acceptance.
   
   ## [SIP] Proposal for Decouple Service and Container port to support adding 
reverse proxy 'sidecar'
   
   ### Motivation
   
   To efficiently serve the static files, the use of a reverse proxy http 
server is possible with the extraContainers value and a shared volume between 
the two containers. The problem is that the service forwards traffic to the 
superset port (Values.service.port) on the POD. To allow the nginx sidecar to 
serve traffic and split between static and the supersetNode container, the 
service needs to serve traffic on the nginx port of the POD.
   
   ### Proposed Change
   I propose the values.service.port gets decoupled from the newly introduced 
supersetPort value. The supersetPort value will be used in the deployment.yaml 
to set the containerPort and SUPERSET_PORT env variable, whereas the 
values.service.port will be used to point to the port that should be used as 
the http interface. To avoid breaking changes maybe the supersetPort can 
default to the service.port?
   
   ### New or Changed Public Interfaces
   -
   
   ### New dependencies
   -
   
   ### Migration Plan and Compatibility
   -
   
   ### Rejected Alternatives
   -
   
   Happy to open a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to