michael-s-molina commented on code in PR #24703: URL: https://github.com/apache/superset/pull/24703#discussion_r1266779579
########## superset/migrations/shared/migrate_viz/base.py: ########## @@ -31,6 +32,12 @@ Base = declarative_base() +class ChartMigratorStatus(Enum): Review Comment: It's only the Area migration that is incomplete. I don't think it's a good idea to create this enum because we don't want to allow incomplete or not implemented migrations. Can we assume that all new migrations should be complete and just skip area for now when importing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
