john-bodley commented on code in PR #24731:
URL: https://github.com/apache/superset/pull/24731#discussion_r1267197694
##########
requirements/integration.txt:
##########
@@ -45,17 +45,22 @@ platformdirs==3.8.1
pluggy==1.2.0
# via tox
pre-commit==3.3.3
- # via -r integration.in
+ # via -r requirements/integration.in
pyproject-api==1.5.2
# via tox
pyproject-hooks==1.0.0
# via build
-pyyaml==5.4.1
+pyyaml==6.0.1
# via pre-commit
+tomli==2.0.1
Review Comment:
I'm not sure why this wasn't present previously. Possibly a problematic
failed prior run of `pip-compile-multi` and/or pinning requirements outside of
said tool.
##########
requirements/testing.txt:
##########
@@ -16,6 +16,8 @@ cmdstanpy==1.1.0
# via prophet
contourpy==1.0.7
# via matplotlib
+convertdate==2.4.0
Review Comment:
See previous comment.
##########
requirements/testing.txt:
##########
@@ -121,6 +123,8 @@ pyfakefs==5.2.2
# via -r requirements/testing.in
pyhive[presto]==0.6.5
# via apache-superset
+pymeeus==0.5.12
Review Comment:
See previous comment.
##########
setup.py:
##########
@@ -111,7 +111,7 @@ def get_git_sha() -> str:
"python-dotenv",
"python-geohash",
"pyarrow>=12.0.0, <13",
- "pyyaml>=5.4",
+ "pyyaml>=6.0.0, <7.0.0",
Review Comment:
A side note. It likely would be good (in a follow up PR) to:
1. Add bounds to all packages.
2. Ensure consistent version specification, i.e., adhere to the
`<major>.<minor>.<patch>` version construct (if applicable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
