michael-s-molina commented on code in PR #24599:
URL: https://github.com/apache/superset/pull/24599#discussion_r1268139631
##########
superset-frontend/src/components/WarningIconWithTooltip/index.tsx:
##########
@@ -24,11 +24,13 @@ import { Tooltip } from 'src/components/Tooltip';
export interface WarningIconWithTooltipProps {
warningMarkdown: string;
size?: IconType['iconSize'];
+ indentSize?: number;
Review Comment:
Can you pass `marginRight` as the property instead of `indentSize` and use
`theme.gridUnit * 2` as its default value? It seems more clear what's the
objective. It's hard to grasp that the indent will be added to the margin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
