cccs-tom commented on code in PR #24724: URL: https://github.com/apache/superset/pull/24724#discussion_r1270686348
########## docs/docs/installation/running-on-kubernetes.mdx: ########## @@ -89,7 +89,10 @@ Default security settings and passwords are included but you **SHOULD** override ```yaml postgresql: - postgresqlPassword: superset + auth: + postgresPassword: superset + password: superset Review Comment: In my opinion, it should be made clear that this is only one way to pass credentials to the Bitnami Postgres chart that the Superset chart depends on. In our deployment, we have an external process (Terraform) that creates Secrets for us, so we use the `existingSecret` mechanism from the Postgres chart, which imo is more secure since we're not committing any plaintext password to Git. I think that mentioning a few of the options and linking to the [Postgres chart's documentation](https://artifacthub.io/packages/helm/bitnami/postgresql) or even the [Postgres chart's values file](https://github.com/bitnami/charts/blob/main/bitnami/postgresql/values.yaml) would be much more suitable. It is also worth noting that the Postgres chart is an optional dependency and people are free to "bring their own" Postgres... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
