michael-s-molina commented on PR #24698: URL: https://github.com/apache/superset/pull/24698#issuecomment-1645619774
> @michael-s-molina I think it makes sense to make the autoClearSearchValue an option that can be controlled from the wrappers. I am looking at the Dashboard properties to set owners. I don't think this functionality is very useful in that sense and it might be confusing as well. What do you think? Maybe we can consider that for a future iteration. I exposed `autoClearSearchValue` as a property and now it can be overridden as you suggested. > I found a small issue. When clicking on the input when there is a search value, the search value disappears. I think we need to control the target of the click. This is a bug with Ant Design that was fixed on version 4.24.5 which is some leap from our current 4.10.3 version. Unfortunately, we may delay this fix until Ant Design is upgraded. > Another weird aspect of the Select, that has nothing to do with this PR, but that I'd like to point out. When hitting Enter on a new search value, I am expecting that the value will be added to the options, like it happens when there is no other match and the value is new. However, when the search value matches with an already selected value that is focused, hitting Enter not only does not select the search value, but deselects the focused value, which is super confusing. I'll deal with this bug in a follow-up to provide proper context. Thank you so much for testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
