villebro commented on code in PR #24755:
URL: https://github.com/apache/superset/pull/24755#discussion_r1271864168
##########
superset/examples/deck.py:
##########
@@ -387,6 +387,7 @@ def load_deck_dash() -> None: # pylint:
disable=too-many-statements
"stroked": False,
"extruded": True,
"multiplier": 0.1,
+ "line_width": 10,
Review Comment:
Shouldn't we also add `"line_width_unit": "meters"` here, as the default
unit is now being changed?
##########
superset/migrations/versions/2023-07-19_17-54_ee179a490af9_deckgl_path_width_units.py:
##########
@@ -0,0 +1,68 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""deckgl-path-width-units
+
+Revision ID: ee179a490af9
+Revises: 863adcf72773
+Create Date: 2023-07-19 17:54:06.752360
+
+"""
+import json
+
+import sqlalchemy as sa
+from alembic import op
+from sqlalchemy import Column, Integer, or_, String, Text
+from sqlalchemy.ext.declarative import declarative_base
+
+from superset import db
+
+# revision identifiers, used by Alembic.
+revision = "ee179a490af9"
+down_revision = "863adcf72773"
+
+
+Base = declarative_base()
+
+
+class Slice(Base):
+ __tablename__ = "slices"
+ id = Column(Integer, primary_key=True)
+ viz_type = Column(String(250))
+ params = Column(Text)
+
+
+def upgrade():
+ bind = op.get_bind()
+ session = db.Session(bind=bind)
+ for slc in session.query(Slice).filter(
+ or_(
+ Slice.viz_type == "deck_path",
+ Slice.viz_type == "deck_geojson",
+ Slice.viz_type == "deck_polygon",
+ )
+ ):
+ params = json.loads(slc.params)
+ if not params.get("line_width_unit"):
+ params["line_width_unit"] = "meters"
+ slc.params = json.dumps(params)
Review Comment:
I assume that this will impact nearly all charts that are found by the
filter clause. But I agree, adding the indentation here is more prudent and
will avoid unnecessary db work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
