michael-s-molina commented on code in PR #24772:
URL: https://github.com/apache/superset/pull/24772#discussion_r1272197531
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -81,6 +81,12 @@ export interface ResultSetProps {
defaultQueryLimit: number;
}
+const ResultContainer = styled.div`
+ display: flex;
+ flex-direction: column;
+ gap: ${({ theme }) => theme.gridUnit * 2}px;
Review Comment:
This is adding space vertically and horizontally while previously we had
only vertical spacing with `padding: ${({ theme }) => 2 * theme.gridUnit}px
0;`. Is this intended or should we use `row-gap`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
