john-bodley commented on issue #24782: URL: https://github.com/apache/superset/issues/24782#issuecomment-1648726754
As a follow up I gather creating a copy of the dashboard (see screenshot) should also likely be forbidden, i.e., said user is stepping beyond the intent of the dashboard owner(s) who provided the RBAC to the role. <img width="235" alt="Screenshot 2023-07-24 at 3 41 04 PM" src="https://github.com/apache/superset/assets/4567245/b0f4a0a8-173b-45e6-91ca-f4aa325fb69a";> Spelunking through the code I _think_ [this](https://github.com/apache/superset/blob/master/superset/security/manager.py#L1850-L1853) is likely one part of the logic which should change, i.e., access to the underly ing dataset should be context aware—granted only in the context of an accessible dashboard. Sadly complicated logic doesn't bode well from a security/access perspective and thus I wonder in a future release whether we should consider reverting this feature given the complexity of how/where these controls are enforced—be that within the security manager, filters, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
