Vitor-Avila opened a new pull request, #24808: URL: https://github.com/apache/superset/pull/24808
### SUMMARY When granting dashboard access to a guest user, it's only granted access to datasets used by its charts. If the dashboard has any native filters powered by datasets that aren't used by any chart, the filter wouldn't load with a permission error. This PR changes this logic to also allow access to datasets used by filters. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF #### Before <img width="794" alt="image" src="https://github.com/apache/superset/assets/96086495/d6bb3d1d-04f3-44fc-ab4e-9a87163e5090";> #### After <img width="800" alt="image" src="https://github.com/apache/superset/assets/96086495/c5e0e7ba-aa1c-4ed0-89f0-cffd99ec561d";> ### TESTING INSTRUCTIONS 1. Create a chart using any dataset. 2. Save the chart and add it to a dashboard. 3. Create a virtual dataset for the same table (a `select * ...` would be enough). 4. Create a dashboard filter using the virtual dataset. 5. Enable embedded access for the dashboard. 6. Create a `guest_token` and grant access to this dashboard. 7. Access this dashboard in embedded mode. 8. Validate that the dashboard filter loads properly. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: Fixes #24807 - [X] Required feature flags: `EMBEDDED_SUPERSET = True` - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
