michael-s-molina commented on code in PR #24829:
URL: https://github.com/apache/superset/pull/24829#discussion_r1278025467
##########
superset-frontend/src/features/datasets/styles.ts:
##########
@@ -25,22 +25,22 @@ export const StyledLayoutWrapper = styled.div`
background-color: ${({ theme }) => theme.colors.grayscale.light5};
`;
-const Column = styled.div`
+const Column = styled.div<{ width?: number }>`
Review Comment:
Given that `LeftColumn` and `RightColumn` are pretty much overriding the
properties of `Column`, could you remove `Column`? I think it will be way more
readable.
```
export const LeftColumn = styled.div<{ theme: SupersetTheme; width?: number
}>`
width: ${({ theme, width }) => width ?? theme.gridUnit * 80}px;
height: auto;
flex-direction: column;
`;
export const RightColumn = styled.div`
width: auto;
height: auto;
display: flex;
flex: 1 1 auto;
flex-direction: column;
`;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
