justinpark commented on code in PR #24847:
URL: https://github.com/apache/superset/pull/24847#discussion_r1281045666


##########
superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.test.ts:
##########
@@ -267,3 +267,49 @@ test('returns column keywords among selected tables', 
async () => {
     ),
   );
 });
+
+test('returns long keywords with docText', async () => {

Review Comment:
   The one of the main reason I introduced useKeywords hook is this. It's hard 
to render AceEditor in testing library due to the complex dependancies.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to