john-bodley commented on code in PR #24874:
URL: https://github.com/apache/superset/pull/24874#discussion_r1282462044
##########
superset-frontend/packages/superset-ui-core/test/query/types/AnnotationLayer.test.ts:
##########
@@ -93,7 +93,6 @@ describe('AnnotationLayer type guards', () => {
},
];
const recordAnnotationResult: RecordAnnotationResult = {
- columns: ['col1', 'col2'],
Review Comment:
LOL. The `columns` here should be the same columns as the `records` which is
the output of the conversion of a Pandas DataFrame to a dictionary, i.e., this
should have read,
```javascript
columns: ['a', 'b']
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
