john-bodley commented on PR #24804: URL: https://github.com/apache/superset/pull/24804#issuecomment-1666173582
@eschutho and @Vitor-Avila as mentioned in https://github.com/apache/superset/pull/24892 this refactor should help with your efforts in readdressing the problem outlined in https://github.com/apache/superset/pull/24808 as now the `raise_for_access` method is dashboard (context) aware, i.e., the caller could be mutated to be of the form, ```python security_manager.raise_for_access(dashboard=dashboard, datasource=datasource) ``` as opposed to ```python security_manager.raise_for_access(datasource=datasource) ``` or similar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
