john-bodley commented on code in PR #24894:
URL: https://github.com/apache/superset/pull/24894#discussion_r1286376208
##########
superset/daos/chart.py:
##########
@@ -41,16 +41,14 @@ class ChartDAO(BaseDAO[Slice]):
@classmethod
def delete(cls, items: Slice | list[Slice], commit: bool = True) -> None:
- item_ids = [item.id for item in get_iterable(items)]
Review Comment:
@jfrag1 the reason this logic is required is because `ON DELETE CASCADE`
isn't configured. The right solution would be (in a separate PR) to replicate
the logic outlined in https://github.com/apache/superset/pull/24628 for the
`dashboard_slices` table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
