john-bodley commented on code in PR #24938:
URL: https://github.com/apache/superset/pull/24938#discussion_r1289266952
##########
superset/daos/dashboard.py:
##########
@@ -195,11 +195,6 @@ def update_charts_owners(model: Dashboard, commit: bool =
True) -> Dashboard:
@classmethod
def delete(cls, items: Dashboard | list[Dashboard], commit: bool = True)
-> None:
item_ids = [item.id for item in get_iterable(items)]
- # bulk delete, first delete related data
- for item in get_iterable(items):
- item.slices = []
- item.embedded = []
Review Comment:
This doesn't seem necessary per the way the [relationship is
defined](https://github.com/apache/superset/blob/master/superset/models/dashboard.py#L166-L170).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
