john-bodley commented on code in PR #24949:
URL: https://github.com/apache/superset/pull/24949#discussion_r1290432021
##########
superset/db_engine_specs/elasticsearch.py:
##########
@@ -123,7 +123,7 @@ def convert_dttm(
sqla_type = cls.get_sqla_column_type(target_type)
if isinstance(sqla_type, types.DateTime):
- return f"""'{dttm.isoformat(timespec="seconds")}'"""
+ return f"""'{dttm.isoformat(sep=" ", timespec="seconds")}'"""
Review Comment:
@hhhonzik would you mind adding some unit tests for this? You can find
examples of these with the other DB engine specs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
