villebro commented on code in PR #24982: URL: https://github.com/apache/superset/pull/24982#discussion_r1294072849
########## tests/integration_tests/datasource_tests.py: ########## @@ -105,6 +105,7 @@ def test_external_metadata_by_name_for_physical_table(self): "database_name": tbl.database.database_name, "schema_name": tbl.schema, "table_name": tbl.table_name, + "normalize_columns": tbl.normalize_columns, Review Comment: Good idea, I'll do that 👍 ########## tests/integration_tests/datasource_tests.py: ########## @@ -105,6 +105,7 @@ def test_external_metadata_by_name_for_physical_table(self): "database_name": tbl.database.database_name, "schema_name": tbl.schema, "table_name": tbl.table_name, + "normalize_columns": tbl.normalize_columns, Review Comment: Good idea, I'll do that 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org