john-bodley commented on PR #25031: URL: https://github.com/apache/superset/pull/25031#issuecomment-1684841369
@villebro I was talking with @michael-s-molina earlier this week and plan to write a SIP about DAOs. The plan is—as you pointed out—that one shouldn't commit within a DAO but rather on a unit of work. I hope to have the SIP drafted earlier next week which will also mention SQLAlchemy nested transactions, which as the name suggests, allows for one to nest operations (leveraging `SAVEPOINTS`) which ensures one of two states, the transaction is committed or rolled back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
