zephyring opened a new pull request, #25043: URL: https://github.com/apache/superset/pull/25043
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The `perm` and `schema_perm` attributes for dataset model is out of sync due to unreliably using sqlalchemy `get_history` method where the history state depends on whether the session has flushed or not. Previously we have logic in `before_update` and `after_update` and permission sync logic in `after_update` will not be deterministic due to session flush. This PR moves permission sync logic into `before_update` and directly using connection.execute to check current db state instead of relying on session state to make sure we can detect actual db/table/schema changes to trigger permission update. It also clean up shadow_dataset_write logic out as we no longer support it but the database attribute is still not lazily loaded when dataset.database attribute is accessed. Thus I leave the `load_database` method there still. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
