michael-s-molina opened a new pull request, #25074: URL: https://github.com/apache/superset/pull/25074
### SUMMARY This PR fixes a bug in the initialization of cross filters scope. The algorithm was not considering dashboards that were created before `DASHBOARD_CROSS_FILTERS` was enabled. `metadata.global_chart_configuration.scope` might not exist and that was generating an error. Fixes https://github.com/apache/superset/issues/25064 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <img width="1172" alt="Screenshot 2023-08-24 at 11 23 03" src="https://github.com/apache/superset/assets/70410625/454baabb-f7ab-41be-9e72-72f0062505ae";> <img width="1772" alt="Screenshot 2023-08-24 at 11 22 41" src="https://github.com/apache/superset/assets/70410625/8fd7b8c0-6900-4b18-8cd9-637c0b800e02";> ### TESTING INSTRUCTIONS - Create a dashboard with DASHBOARD_CROSS_FILTERS disabled - Enable `DASHBOARD_CROSS_FILTERS` - Navigate to the created dashboard - It should not throw the mentioned error ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
