Mattc1221 commented on PR #24154: URL: https://github.com/apache/superset/pull/24154#issuecomment-1692891200
Thanks @kgabryje for the detailed review, I believe I've addressed all of your comments! > * I can change the contour type from isoline to isoband, but I can't do the opposite - when I edit an isoband, change the tab to isoline and type value, it only edits the lower threshold of isoband. I think user could expect that the contour becomes an isoline. > * The popover should close after clicking save > * Maybe we should have some kind of validation to ensure that upper threshold is larger than lower threshold? You should now be able to change isobands to isolines, the Save button closes the form, I've added some validation messages and disabled saving when the lower threshold is greater than or equal to the upper threshold. The tooltip should now appear with the lat/long coordinates as well as the threshold for whatever contour the mouse is hovering. https://github.com/apache/superset/assets/36670322/02e7cb41-183b-4932-95c8-1a51bcddfa1a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
