jfrag1 commented on PR #25086: URL: https://github.com/apache/superset/pull/25086#issuecomment-1693900879
> @jfrag1 Is is possible to refactor and extract said logic to a utility function or something else to avoid the copy/paste? Yes it is of course possible, but due to the amount of duplication present, I think the refactor required to eliminate this duplication warrants its own PR and review process. Just check the `_import` methods of `ImportDashboardsCommand`, `ImportChartsCommand`, and `ImportAssetsCommand` to see. IMO it's ok to merge this fix PR separately since it's not really making the duplication harder to untangle (the code copied here is already duplicated between the chart and dashboard import commands). cc @betodealmeida as I just noticed there's a relevant todo comment he left -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
