justinpark opened a new pull request, #25091: URL: https://github.com/apache/superset/pull/25091
### SUMMARY When ResultSet renders a large size of column record (i.e. preview of FCC 2018 Survey), rendering cost of VirtualizedTable is heavy. To avoid the lag of the typing editor, we should avoid the ResultSet rendering while typing. This commit fixes the inefficient userSelector in ResultSet which triggers the re-rendering of FilterableTable anytime redux action triggered. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF After (no lag while typing): https://github.com/apache/superset/assets/1392866/3e346d56-aa7c-4852-9a6a-db0f8a145e9b Before (lagging): https://github.com/apache/superset/assets/1392866/1774e4e4-57bd-4765-a11f-3b881b7f5356 ### TESTING INSTRUCTIONS Load example db Go to SQL Lab and select the 'FCC 20218 Survey' in the table schema After the preview result loaded, type the sql in the editor to check the lagging ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
