justinpark commented on code in PR #25088:
URL: https://github.com/apache/superset/pull/25088#discussion_r1306211893
##########
superset-frontend/src/views/store.ts:
##########
@@ -113,6 +122,7 @@ const CombinedDatasourceReducers = (
};
const reducers = {
+ ...sqlLabReducers,
Review Comment:
agree everything except localStorageUsage part. it's still used in [the
persist
logic](https://github.com/apache/superset/blob/master/superset-frontend/src/SqlLab/App.jsx#L86)
to warn the limit size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
