justinpark opened a new pull request, #25114: URL: https://github.com/apache/superset/pull/25114
### SUMMARY This commit fixes the address https://github.com/apache/superset/issues/25111 issue When a table schema is already populated and synced with remote id, the autocomplete can trigger 'MERGE_TABLE' with the already referenced table. This action can overwrite the remote id by the auto-gen id. This commit fixes this bug by skipping the overwrite the remote id. This commit also fixes the unexpected narrow gap between table control buttons due to the icon migration from font-awesome to antd icons ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF - After https://github.com/apache/superset/assets/1392866/e214d538-6850-4b65-8058-1146f137c7fb - Before https://github.com/apache/superset/assets/1392866/0555a6e8-1f49-43d6-a951-f1d181e3930a - icon gap update |After|Before|Before under font-awesome| |--|--|--| |||| ### TESTING INSTRUCTIONS set SQLLAB_BACKEND_PERSISTENCE True Go to SQLLAB and enable autocomplete Select a table in the table schema selector Type some table name which is selected above Click the same table from the autocomplete Remove the table by the table action button Check the error ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
