eschutho commented on code in PR #25118:
URL: https://github.com/apache/superset/pull/25118#discussion_r1309455921
##########
docs/docs/installation/event-logging.mdx:
##########
@@ -56,5 +56,13 @@ from superset.stats_logger import StatsdStatsLogger
STATS_LOGGER = StatsdStatsLogger(host='localhost', port=8125,
prefix='superset')
```
+You can also pass metric names that should be ignored via an optional
`metric_denylist` parameter:
+
+```
+STATS_LOGGER = StatsdStatsLogger(host='localhost', port=8125,
prefix='superset', metric_denylist={"reports.scheduler"})
Review Comment:
@zephyring or @craig-rueda mentioned a good point that there's no guarantee
that a metric name might not change. What do you all think about having an enum
of strings that we can reference instead? It will have to be maintained and
updated of course, but at least then we can export it and refer to the enum in
the config rather than the string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
