KSPT-taylorjohn commented on issue #25073: URL: https://github.com/apache/superset/issues/25073#issuecomment-1699720844
Thanks @villebro. I might not be understanding correctly, but I don't think the problem is the labels matching of the outer and inner queries the join built starting at https://github.com/apache/superset/blob/29355577f148d1210c40043ef6028804469d2c30/superset/models/helpers.py#L1964-L1965 Because the ```groupby_series_columns``` isn't being populated in the first place. What I did to fix it was simply change the outer.name to outer.key for checking if the created outer column is in the list of the series_column_names ```python if ( is_timeseries and not series_column_names ) or outer.key in series_column_names: groupby_series_columns[outer.name] = outer select_exprs.append(outer) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
