john-bodley commented on code in PR #24776:
URL: https://github.com/apache/superset/pull/24776#discussion_r1311087487
##########
superset/migrations/shared/migrate_viz/base.py:
##########
@@ -141,10 +141,9 @@ def upgrade_slice(cls, slc: Slice) -> Slice:
if "form_data" in (query_context := try_load_json(slc.query_context)):
query_context["form_data"] = clz.data
slc.query_context = json.dumps(query_context)
- return slc
Review Comment:
Previously this was returning the same object as the one being passed in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
