michael-s-molina commented on PR #25151: URL: https://github.com/apache/superset/pull/25151#issuecomment-1702593226
Hi @eschutho. Just to add a little more context. I asked @justinpark to include the cleanup of old code in the same PR given that: - Some features might work because of old code and they shouldn't. We should validate SPA considering that the old code has no influence in the project. - The PR is big and requires a lot of testing and validation. It's good if we do this only once. If we do the cleanup work later, we'll need to repeat the same extensive test process. Just to be clear, removing old code shouldn't mean introducing breaking changes. Let's make sure that's the case when reviewing the PR. Once code review is completed, we'll create a test environment to make sure everything is working. It would be great if @sadpandajoe and @jinghua-qa could help us out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
